Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Parameter that is used to select the storeView must be named store #15

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

remiebelingmerifond
Copy link

@remiebelingmerifond remiebelingmerifond commented Nov 3, 2022

This example is from the docs.

Storeview parameter has no impact:

$result = $proxy->catalogCategoryInfo(
  (object)array(
    'sessionId' => $sessionId->result,
    'categoryId' => '123',
    'storeView' => 2
  )
);

In Order to select the correct storeView you have to use::

$result = $proxy->catalogCategoryInfo(
  (object)array(
    'sessionId' => $sessionId->result,
    'categoryId' => '123',
    'store' => 2
  )
);

You can also have a look at the definition of catalog_category.info in the wsi file of the Catalog Module

https://github.com/OpenMage/magento-lts/blob/8774526ece4a406cf3455236d17bb67ff14e334e/app/code/core/Mage/Catalog/etc/wsi.xml#L1416

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

When this pull request is merged, it will...

Fix a misleading information regarding the params of catalogCategoryInfo api method

Additional information

List all affected URLs

[- ...

  • ...

](https://devdocs-openmage.org/guides/m1x/api/soap/catalog/catalogCategory/catalog_category.info.html)

…med `store`

This selects the correct storeView:

```
$result = $proxy->catalogCategoryInfo(
  (object)array(
    'sessionId' => $sessionId->result,
    'categoryId' => '123',
    'store' => 2
  )
);

```
This is ignored:
```
$result = $proxy->catalogCategoryInfo(
  (object)array(
    'sessionId' => $sessionId->result,
    'categoryId' => '123',
    'store' => 2
  )
);
```
@tmotyl
Copy link

tmotyl commented Nov 4, 2022

@remiebelingmerifond both examples you posted are exactly the same. Please edit to show the difference.

@remiebelingmerifond
Copy link
Author

@tmotyl sorry i was a little to fast yesterday.
I Updated the examples.

And i just had a closer look.

I am not an expert in these WSDL and WSI Definiition things.
But as far as i can tell, the actual Problem seems to be, that there is a difference between th wsdl and wsi definiitions.

WSDL:
https://github.com/OpenMage/magento-lts/blob/8774526ece4a406cf3455236d17bb67ff14e334e/app/code/core/Mage/Catalog/etc/wsdl.xml#L1108-L1113

WSI:
https://github.com/OpenMage/magento-lts/blob/8774526ece4a406cf3455236d17bb67ff14e334e/app/code/core/Mage/Catalog/etc/wsi.xml#L1411-L1420

So maybe we should add an info that – depending if you youse wsi compliant mode, the parrameter is named store instead of storeView

i'll give it a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants