Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] sync dashboard #404

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[WIP] sync dashboard #404

wants to merge 13 commits into from

Conversation

eelcovdw
Copy link
Contributor

@eelcovdw eelcovdw commented Nov 18, 2024

Description

  • localstate now logs both state after successful sync, and status info on both success and error.
    • TODO log rejected files (no permissions, etc) with a rejected status, error status should be for connection/server errors
  • local state now logs ignored files
  • remove localstate init from consumer and add to manager. This way, producer has access to localstate too
  • move producer logic from manager to new SyncProducer
  • move common sync types to types.py to avoid circular imports
    • TODO cleanup enums with the same function in types.py
  • change errorhandling in consumer so we can log failures to localstate

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant