Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup sync and log sync status locally #443

Merged
merged 18 commits into from
Nov 27, 2024
Merged

Conversation

eelcovdw
Copy link
Contributor

@eelcovdw eelcovdw commented Nov 26, 2024

Description

  • localstate now logs both state after successful sync, and status info on both success and error.
  • local state now logs ignored files
  • move shared types, producer logic and localstate to more sensible place
  • change errorhandling in consumer so we can log failures to localstate

TODO

  • add simple sync dashboard html + endpoint
  • to list queued/inprogress items, sync router needs access to SyncManager. Not possible with syftclient interface, causes a circular dependency
  • cleanup enums with the same function in sync/types.py
  • log rejected files (no permissions, etc) with a rejected status, error status should be for unexpected connection/server errors

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

router = APIRouter()


@router.get("/data")
Copy link
Contributor Author

@eelcovdw eelcovdw Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed this with @yashgorana , we made some changes so we can read SyncManager state directly (instead of from local_state file). Will be included in next PR

@eelcovdw eelcovdw merged commit be358cd into main Nov 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants