OPG-493: Fix mapping of subAttribute and datasource in Perf DS #1041
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mershad-manesh
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NMS-16582 may be caused by the fact that
subAttributeanddatsourceare not correctly mapped in OPG v9 for Performance queries.This fixes the mapping from the OPG query builder UI (
Sub-Attribute) and also changes the name fromsubAttributetodatasourcefor the query to OpenNMS Measurements Rest API. It also fixes the dashboard converter to map it correctly.Additionally, we use a Python script
check_jsonschemato validate oursrc/plugins.jsonfile during the Circle CI build process. The schema file we use has some Python-regex specific formulations like\\-and\\%. Needed to add--regex-variant pythonto account for this; apparently the default is not to use those Python-specific regex elements.External References