Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMS-16978: Changed eventId to long #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NMS-16978: Changed eventId to long #176

wants to merge 1 commit into from

Conversation

christianpape
Copy link
Contributor

mershad-manesh
mershad-manesh previously approved these changes Dec 17, 2024
View reviewed changes
@cgorantla
Copy link
Contributor

Since this is breaking change, I would put this in master branch.
Also It would be good to have this PR pending and able to validate changes on OpenNMS. But If you need to run CI/CD we need this to be merged. I'm okay to merge but on master

cgorantla
cgorantla reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-base this to master to be on 2.x snapshot

@christianpape christianpape changed the base branch from release-1.x to master December 18, 2024 07:02
@christianpape christianpape dismissed mershad-manesh’s stale review December 18, 2024 07:02

The base branch was changed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@christianpape
Copy link
Contributor Author

Please re-base this to master to be on 2.x snapshot

Master will require JDK 17. This means OpenNMS must also be built with JDK 17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mershad-manesh mershad-manesh Awaiting requested review from mershad-manesh

@cgorantla cgorantla Awaiting requested review from cgorantla

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christianpape @cgorantla @mershad-manesh