Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS-16978: Changed event's primary key to BIGINT #7565

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Conversation

christianpape
Copy link
Contributor

@dino2gnt
Copy link
Contributor

dino2gnt commented Jan 8, 2025

Should the sequences now also CYCLE? I think 9 quintillion IDs makes that pretty safe.

opennms=# \d+ eventsnxtid
                        Sequence "public.eventsnxtid"
  Type  | Start | Minimum |       Maximum       | Increment | ***Cycles?*** | Cache
--------+-------+---------+---------------------+-----------+---------------+-------
 bigint |     1 |       1 | 9223372036854775807 |         1 | *** no ***    |     1

Copy link
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christianpape christianpape merged commit b485b88 into develop Jan 28, 2025
18 checks passed
@christianpape christianpape deleted the jira/NMS-16978 branch January 28, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants