NMS-16573 User tries to create an Alarm filter favorite, but the filter doesn't save the arguments of the filter #7596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smunir-onms
reviewed
Jan 17, 2025
cgorantla
reviewed
Jan 29, 2025
| @@ -247,6 +258,30 @@ public static Filter getFilter(String[] allFilters, String filterString, Servlet | |||
| } | |||
| } else if (type.equals(InterfaceFilter.TYPE)) { | |||
| filter = new InterfaceFilter(InetAddressUtils.addr(value)); | |||
| } else if (type.equals(ConditionalFilter.TYPE)) { | |||
| String cleanedValue = value.substring(1, value.length() - 1); // Remove surrounding brackets | |||
There was a problem hiding this comment.
Can we check if there are surrounding brackets exists then only clean it up as the behavior can change.
There was a problem hiding this comment.
ConditionalFilter always has a brackets even if their is only one parameter, because it stores data in an array. Do you still want me check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External References