NMS-17066: Fix Measurement TrendLine #7597
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrendLine was nnot able to parse Long Term measument data because was not able to manage Double.NaN. Added unit test with real data fetched
cgorantla
changed the title
cgorantla
reviewed
Jan 22, 2025
| @@ -0,0 +1,95 @@ | |||
| /******************************************************************************* | |||
| * This file is part of OpenNMS(R). | |||
There was a problem hiding this comment.
copyright headers can be updated to new header that is independent of year.
see copyright header on TrendLine.java
christianpape
requested changes
Jan 23, 2025
| for (long i = limits.firstRowWithValues; i < limits.lastRowWithValues; i++) { | ||
| obs.add(table.get(i, TIMESTAMP_COLUMN_NAME), table.get(i, m_inputColumn)); | ||
| for (long i = limits.firstRowWithValues; i <= limits.lastRowWithValues; i++) { | ||
| Double value = table.get(i,m_inputColumn); |
There was a problem hiding this comment.
Suggested change
| Double value = table.get(i,m_inputColumn); | |
| Double value = table.get(i, m_inputColumn); |
| @@ -124,5 +120,7 @@ public void filter(RowSortedTable<Long, String, Double> table) throws RScriptExc | |||
| // Compute the value | |||
| table.put(i, m_outputColumn, polynomialFunction.value(timestamp)); | |||
| } | |||
| LOG.debug("filter: values:\n{}", table.rowMap().values()); | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TrendLine was nnot able to parse Long Term measument data because was not able to manage Double.NaN.
Added unit test with real data fetched