Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-#: Adds METHOD, DNS and GATEWAY parameters to VM template NIC docs #3114

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aleixrm
Copy link
Member

@aleixrm aleixrm commented Nov 28, 2024

Description

Adds NIC configuration missing parameters to the VM template attribute reference.

Based on tf provider docs: https://registry.terraform.io/providers/OpenNebula/opennebula/latest/docs/resources/virtual_machine#method-1

Branches to which this PR applies

  • master
  • one-X.X
  • one-X.X-maintenance

  • Check this if this PR should not be squashed

Copy link
Contributor

@pedroielpi3 pedroielpi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For line 516 I suggest adding the backticks `` to the key=value pair, i.e.:

NIC DNS server. Please make sure that INHERIT_VNET_ATTR="DNS" is added to /etc/one/oned.conf.

Otherwise looks good to me

@aleixrm
Copy link
Member Author

aleixrm commented Nov 28, 2024

For line 516 I suggest adding the backticks `` to the key=value pair, i.e.:

NIC DNS server. Please make sure that INHERIT_VNET_ATTR="DNS" is added to /etc/one/oned.conf.

Otherwise looks good to me

Sorry, I forgot it! Corrected 😄

@aleixrm aleixrm requested a review from pedroielpi3 November 28, 2024 16:31
Copy link
Contributor

@pedroielpi3 pedroielpi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants