Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F #79: Harbor code + persistency #87
F #79: Harbor code + persistency #87
Changes from 2 commits
7b57e83
159d297
9b248ee
3a022a9
25fcb1c
7ad0999
7745f4a
cf9d659
957ee23
9b5141f
dd2dc54
6015298
38b1f59
0724967
e7dac9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll probably need a better way of getting the device, maybe a USER INPUT? so vda will depend on the driver used (e.g. sd vs vd) and the number of disks in the VM template. So probably the safest thing is to let the user input which device should be used for persistent data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ext4? The volume can be xfs, we may get this from the VM template but maybe it is not there so we may need to use a blkinfo or similar