Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-485: add datasource opennebula vms #536

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

treywelsh
Copy link
Collaborator

@treywelsh treywelsh commented Mar 28, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

Introduce opennebula_virtual_machines datasource, and add some fixes around opennebula_templates.

References

Close #485

New or Affected Resource(s)

  • data_opennebula_virtual_machines

Checklist

  • I have created an issue and I have mentioned it in References
  • My code follows the style guidelines of this project (use go fmt)
  • My changes generate no new warnings or errors
  • I have updated the unit tests and they pass succesfuly
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (if needed)
  • I have updated the changelog file

@treywelsh treywelsh requested a review from frousselet April 17, 2024 09:05
@frousselet
Copy link
Collaborator

Wait while merging 1.4.1 PR first.

Copy link

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

Copy link

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

Copy link

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

Copy link

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

@rsmontero rsmontero added this to the 1.4.2 milestone Oct 21, 2024
@jaimecb jaimecb self-requested a review November 15, 2024 07:57
Copy link
Collaborator

@sk4zuzu sk4zuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sk4zuzu sk4zuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it back :trollface: , this PR needs to be fixed. One example of incorrect behavior is if VCPU is missing from the template then the VM cannot be found, those kinds of errors...

@jaimecb jaimecb force-pushed the F-485-data-opennebula_vms branch from 59dbc68 to e97c204 Compare November 26, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Source to get list of VMs by name
5 participants