-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F-485: add datasource opennebula vms #536
base: master
Are you sure you want to change the base?
Conversation
Wait while merging 1.4.1 PR first. |
This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days. |
This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days. |
This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days. |
This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it back , this PR needs to be fixed. One example of incorrect behavior is if VCPU is missing from the template then the VM cannot be found, those kinds of errors...
Signed-off-by: Jaime <[email protected]>
Signed-off-by: Jaime <[email protected]>
Signed-off-by: Jaime <[email protected]>
Signed-off-by: Jaime <[email protected]>
59dbc68
to
e97c204
Compare
Community Note
Description
Introduce
opennebula_virtual_machines
datasource, and add some fixes aroundopennebula_templates
.References
Close #485
New or Affected Resource(s)
Checklist
References
go fmt
)