Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b-515: Corrects vlan_id prevalence in vnet creation #581

Open
wants to merge 1 commit into
base: B-515-ignored-vlanid
Choose a base branch
from

Conversation

aleixrm
Copy link
Member

@aleixrm aleixrm commented Dec 3, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

Some suggestions for #561

  • Corrects vlan_id and automatic_vlan_id precedence, and refactors conditional.
  • Adds some tests for checking conflict between vlan_id and automatic_vlan_id and the fixed bug.
  • Some formatting

References

#561
#515

New or Affected Resource(s)

  • opennebula_virtual_network

Checklist

  • I have created an issue and I have mentioned it in References
  • My code follows the style guidelines of this project (use go fmt)
  • My changes generate no new warnings or errors
  • I have updated the unit tests and they pass succesfuly
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (if needed)
  • I have updated the changelog file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant