Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Fix component crash in validation.errors check #3360

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Feb 28, 2025

It's possible to run into this crash with a mix of legacy and schema validator datasets in your my datasets page results.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.95%. Comparing base (e0efa83) to head (3b6074d).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...ro-components/src/search-page/SearchResultItem.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3360      +/-   ##
==========================================
- Coverage   47.03%   46.95%   -0.09%     
==========================================
  Files         600      601       +1     
  Lines       38540    38606      +66     
  Branches     1266     1267       +1     
==========================================
  Hits        18127    18127              
- Misses      20222    20287      +65     
- Partials      191      192       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 22f7118 into master Feb 28, 2025
13 of 15 checks passed
@nellh nellh deleted the fix-search-result-item-crash branch February 28, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant