speedspacechart: fix blinking in speed limit tags by importing images only once #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synar
force-pushed
the
ali/fix-blinking-ui-speedspacechart-again
branch
from
6bec4f1 to
47a4e00
Compare
emersion
reviewed
Nov 8, 2024
ui-speedspacechart/src/components/helpers/drawElements/speedLimitTags.ts
Outdated
Show resolved
Hide resolved
Synar
force-pushed
the
ali/fix-blinking-ui-speedspacechart-again
branch
from
47a4e00 to
6f28907
Compare
emersion
reviewed
Nov 12, 2024
ui-speedspacechart/src/components/layers/SpeedLimitTagsLayer.tsx
Outdated
Show resolved
Hide resolved
emersion
reviewed
Nov 12, 2024
ui-speedspacechart/src/components/layers/SpeedLimitTagsLayer.tsx
Outdated
Show resolved
Hide resolved
emersion
reviewed
Nov 12, 2024
ui-speedspacechart/src/components/layers/SpeedLimitTagsLayer.tsx
Outdated
Show resolved
Hide resolved
emersion
reviewed
Nov 15, 2024
… only once Signed-off-by: Alice Khoudli <[email protected]>
Synar
force-pushed
the
ali/fix-blinking-ui-speedspacechart-again
branch
from
8adcd61 to
54b086f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #427
Last PR #633 approached the issue by reducing how often the layer was redrawn. As a result, blinking was a lot less frequent, but each redrawing still caused blinking.
Instead here we reduce the time it takes to draw the canvas, by removing the (async) image fetching from the drawing logic, and fetching them only once.