Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sctp multihoming support #2077

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

russagit
Copy link
Contributor

@bogdan-iancu bogdan-iancu self-assigned this Apr 14, 2020
@bogdan-iancu bogdan-iancu added this to the 3.1 milestone Apr 14, 2020
@bogdan-iancu
Copy link
Member

Hi @russagit , I'm trying to understand the idea behind the 'Add sctp multihoming support ' commit. If I get it right, via the LISTEN_SCTP_SEC you define only one additional listener for sctp, right ? (btw, multiple definition of that parameter will leak some sockets, only the last being kept and used).

Further, this single extra SCTP socket will be used for ALL the defined SCTP listner, right ?

@russagit
Copy link
Contributor Author

Hi @bogdan-iancu,
Yes, you are right in everything. Since this is my first try with opensips it is clumsy and limited but covers our needs in production at the moment.
I would be glad if someone could modify this to be more universal.

@bogdan-iancu
Copy link
Member

bogdan-iancu commented Apr 16, 2020

@russagit , I understand your point, but in this current format, this PR cannot be accepted - are too many things which are not ok in this approach.
To be a valid PR, it should have the extra socket definition as part of the listener definition listen=sctp:x.y.z.w:1234 extra a.b.c.d:1234; in this way, the additional sockets are per listener, not global.

@russagit russagit closed this Apr 20, 2020
@russagit
Copy link
Contributor Author

Sorry, I have to add that sctp_bindx does not create extra SCTP socket, it just adds extra IP (secondary IP address without port) to existing socket.

@russagit russagit reopened this Apr 20, 2020
@bogdan-iancu
Copy link
Member

Yes, I understand that.
And let's keep this open, maybe someone will find it a good starting point to work out this feature.

@russagit
Copy link
Contributor Author

Hi @bogdan-iancu,
Could you take a look at another try: SIfoxDevTeam@3b4899a
New token sctp_sec_addr added, example of defining sctp with secondary ip address:
listen=sctp:192.168.1.1:5060 sctp_sec_addr 192.168.2.1

@stale
Copy link

stale bot commented May 7, 2020

Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days.

@stale stale bot added the stale label May 7, 2020
@russagit
Copy link
Contributor Author

Hi @bogdan-iancu,
Could you take a look at SIfoxDevTeam@3b4899a

@stale stale bot removed the stale label May 19, 2020
@stale
Copy link

stale bot commented Jun 20, 2020

Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days.

@stale stale bot added the stale label Jun 20, 2020
@stale
Copy link

stale bot commented Jul 20, 2020

Marking as closed due to lack of progress for more than 30 days. If this issue is still relevant, please re-open it with additional details.

@stale stale bot closed this Jul 20, 2020
@kgalinurov
Copy link

Any progress here?

@bogdan-iancu bogdan-iancu reopened this Oct 28, 2020
@stale stale bot removed the stale label Oct 28, 2020
@stale
Copy link

stale bot commented Nov 21, 2020

Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days.

@stale stale bot added the stale label Nov 21, 2020
@stale
Copy link

stale bot commented Dec 24, 2020

Marking as closed due to lack of progress for more than 30 days. If this issue is still relevant, please re-open it with additional details.

@stale stale bot closed this Dec 24, 2020
@bogdan-iancu
Copy link
Member

Last attempt here to revive this ticket

@bogdan-iancu bogdan-iancu reopened this Jan 8, 2021
@stale stale bot removed the stale label Jan 8, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days.

@stale stale bot added the stale label Jul 21, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Marking as closed due to lack of progress for more than 30 days. If this issue is still relevant, please re-open it with additional details.

@stale stale bot closed this Jan 9, 2022
@bogdan-iancu bogdan-iancu reopened this Jan 10, 2022
@stale stale bot removed the stale label Jan 10, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days.

@stale stale bot added the stale label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants