Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): add embedding model #385

Merged
merged 7 commits into from
Nov 1, 2024
Merged

fix(builder): add embedding model #385

merged 7 commits into from
Nov 1, 2024

Conversation

andylau-55
Copy link
Collaborator

  • Provide built-in embedding model BAAI/bge-base-zh-v1.5.
  • Implement getting vector dimensions of the embedding model automatically.

…nt getting vector dimensions of the embedding model automatically
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 1544 files.

Valid Invalid Ignored Fixed
1516 2 26 0
Click to see the invalid file list
  • python/knext/init.rc
  • python/knext/knext/reasoner/rest/models/edge.py
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

@@ -1,15 +1,4 @@
# coding: utf-8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# coding: utf-8
# Copyright 2023 OpenSPG Authors
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
# in compliance with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software distributed under the License
# is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
# or implied.
# coding: utf-8

@andylau-55 andylau-55 requested a review from caszkgui as a code owner November 1, 2024 03:05
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@3f863f8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...der/core/physical/process/VectorizerProcessor.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #385   +/-   ##
=========================================
  Coverage          ?   49.03%           
  Complexity        ?      314           
=========================================
  Files             ?      718           
  Lines             ?    24987           
  Branches          ?     4101           
=========================================
  Hits              ?    12253           
  Misses            ?    11314           
  Partials          ?     1420           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@xionghuaidong xionghuaidong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@caszkgui caszkgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caszkgui caszkgui merged commit 0e687f7 into master Nov 1, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
@andylau-55 andylau-55 deleted the 0.5.1 branch November 21, 2024 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants