Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more wrecks #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added more wrecks #5

wants to merge 1 commit into from

Conversation

zenfunk
Copy link

@zenfunk zenfunk commented Mar 19, 2015

No description provided.

@zenfunk
Copy link
Author

zenfunk commented Mar 19, 2015

Hi All, I added wrecks, obstructions and rocks to the water_points file. I have not tired this on an actual OSM file, because my internet is still too expensive for any substantial traffic. So it would be wise to try it out beforehand in a sandboxed server or so.

@zenfunk zenfunk closed this Mar 19, 2015
@ehrenfeu
Copy link

Sounds nice, but I guess you accidentially closed this pull request, no? I'm re-opening it...

@ehrenfeu ehrenfeu reopened this Mar 19, 2015
@zenfunk
Copy link
Author

zenfunk commented Mar 19, 2015

I actually just learned what a pull request is about 20 minutes ago ;-) - so yes, could very well be. Thanks for reopening it again.

@ehrenfeu
Copy link

Don't worry, nothing bad happened. I just wanted to avoid this one to be overlooked, which would happen very likely if it was closed...

The pull request will automatically be closed when the changes will get merged. To do this, someone (me or somebody else with write access to the repository) has to have a look at your changes and test them first. As times are extremely busy these days, this might take a while.

@malcolmh
Copy link
Contributor

malcolmh commented Jun 7, 2015

Is Jürgen (Rheinskipper) aware of this repository? He is the principal developer & should be the one to test and merge pull requests.

@ehrenfeu
Copy link

ehrenfeu commented Jun 8, 2015

@malcolmh I'm not sure. He didn't seem to be interested in managing the code in an "Open" spirit, at least that was my personal feeling after I asked about the code a couple of times on the dev mailinglist. As I don't consider it a sustainable way for a project if the code only lives on the production server, I eventually put it here on github, mainly for two reasons:

  1. having a backup
  2. allowing interested people to have a look and suggest changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants