Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set ignoredLayers to 4 and added missing outcommented layers for… #169

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

OpenDEM
Copy link
Contributor

@OpenDEM OpenDEM commented Dec 3, 2022

… documentation.

Some issues can be closed.

@wschildbach
Copy link
Collaborator

Hi @OpenDEM ,

I staged this fix at https://test1-alpha.openseamap.org/ ? . Can you take a look whether it works there?

@OpenDEM
Copy link
Contributor Author

OpenDEM commented Dec 7, 2022

Hi @wschildbach, yes, this looks good! Example harbours and gebco depths:
https://test1-alpha.openseamap.org/?zoom=10&lat=54.15300&lon=11.65400&layers=BFTFFTTFFTF0FFFFFFFFFF

index.php Outdated
@@ -97,14 +97,16 @@
var layer_tidalscale; // 16
var layer_permalink; // 17
var layer_waterdepth_trackpoints_100m; // 18
// var layer_elevation_profile_contours; // 19
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you harmonize the indentation in this line?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge once the indentation is in-line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wschildbach Just fixed it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OpenDEM , this is now fixed. @Nautic , FYI.

@wschildbach
Copy link
Collaborator

See also #162 , #157, #91, #24 -- these might potentially be fixed.

@wschildbach wschildbach merged commit a87b354 into OpenSeaMap:master Dec 8, 2022
@OpenDEM
Copy link
Contributor Author

OpenDEM commented Dec 8, 2022

#162 is fixed, but not the other issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants