Skip to content

Commit

Permalink
chore(tests): clean up comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mellodev committed Dec 5, 2024
1 parent b1e0a5c commit 988b73b
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion test/tests/modules/firmware.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ describe('OSApp.Firmware', function () {
});

describe('versionCompare', function () {
// FIXME: sometimes versionCompare returns an integer, other times it returns a boolean! (mellodev)
// FIXME: sometimes versionCompare returns an integer, other times it returns a boolean!
it('should compare versions (equal)', function () {
var result = OSApp.Firmware.versionCompare('3.0.0'.split('.'), '3.0.0'.split('.'));
assert.equal(result, 0);
Expand Down
2 changes: 1 addition & 1 deletion test/tests/modules/language.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ describe('OSApp.Language', function () {


describe.skip('updateLang', function() {
// Skipped due test not properly mocking DOM for jquery - mellodev
// Skipped due test not properly mocking DOM for jquery
var originalStorageSet, originalGetJSON;

beforeEach(function() {
Expand Down
4 changes: 2 additions & 2 deletions test/tests/modules/notifications.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

describe('OSApp.Notifications', function () {
describe.skip('addNotification', function () {
// Skipped due test not properly mocking DOM for jquery - mellodev
// Skipped due test not properly mocking DOM for jquery
var originalNotifications, originalUpdateNotificationBadge;

beforeEach(function () {
Expand Down Expand Up @@ -76,7 +76,7 @@ describe('OSApp.Notifications', function () {
});

describe.skip('updateNotificationBadge', function () {
// Skipped due test not properly mocking DOM for jquery - mellodev
// Skipped due test not properly mocking DOM for jquery
var originalNotifications, original$;

beforeEach(function () {
Expand Down
2 changes: 1 addition & 1 deletion test/tests/modules/programs.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe('OSApp.Programs', function () {
});

it.skip('should call readProgram183 if firmware version is lower than 2.1', function () {
// Skipped due test polluting OSApp object and breaking tests outside this suite - mellodev
// Skipped due test polluting OSApp object and breaking tests outside this suite
OSApp.Firmware.checkOSVersion = function (version) {
return version < 210;
};
Expand Down
2 changes: 1 addition & 1 deletion test/tests/modules/sites.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ describe('OSApp.Sites', function () {
});

it.skip('should call networkFail on failure', function () {
// Skipped due test not properly setting networkFailCalled - mellodev
// Skipped due test not properly setting networkFailCalled
OSApp.currentSession.isControllerConnected = function () { return true; };
OSApp.Firmware.checkOSVersion = function (version) { return version < 216; };
var networkFailCalled = false;
Expand Down
4 changes: 2 additions & 2 deletions test/tests/modules/station-attributes.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

describe.skip('OSApp.StationAttributes', function () {
describe.skip('getMasterOperation', function () {
// Skipped due test functioning properly - mellodev
// Skipped due test functioning properly
var originalSupported, originalCurrentSession;

beforeEach(function () {
Expand Down Expand Up @@ -72,7 +72,7 @@ describe.skip('OSApp.StationAttributes', function () {
});

describe.skip('getIgnoreRain', function () {
// Skipped due test functioning properly - mellodev
// Skipped due test functioning properly
var originalSupported, originalCurrentSession;

beforeEach(function () {
Expand Down

0 comments on commit 988b73b

Please sign in to comment.