Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for script-managed trees, show warning msg #1252

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jimallman
Copy link
Member

As discussed, we should detect studies with script-managed trees and flag them in the curation app. If such a tree is found, this message will appear instead of the normal tree list:
Screen Shot 2020-09-24 at 1 20 07 AM

The test function appears to be working on devtree, but this PR is blocked since such a study won't load properly in the curation web-app. See for example https://devtree.opentreeoflife.org/curator/study/view/tt_217
The footer message that appears points to a Nexson validation error:

Exception in coercing to the required NexSON version for validation.

@jimallman
Copy link
Member Author

Two possible enhancements come to mind, comments welcome:

  • Should we show a tree list if any "normal" trees are also found in the study? So far we've assumed that this will never happen, but we could easily test for both types and show another warning if this is found.

  • Should we show script-managed trees in a simplified tree list? This would mainly be useful so that a curator can toggle such trees into/out of the main synthesis collection. (Perhaps this is best done by experts with the raw tree data in hand?)

@jimallman
Copy link
Member Author

We now have sensible behavior (in all tabs) for studies with script-managed-trees. Since these have no internal otus, the Analysis tools will be disabled. Working now on devtree, see these examples:

@jimallman
Copy link
Member Author

Stand by on this PR until we have a more satisfying way to handle export options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants