Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for bind-dev in DCO options #690

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BCurrell
Copy link

Thank you for your contribution

You are welcome to open PR, but they are used for discussion only. All
patches must eventually go to the openvpn-devel mailing list for review:

Please send your patch using git-send-email. For example to send your latest commit to the list:

$ git send-email [email protected] HEAD~1

For details, see these Wiki articles:

@BCurrell
Copy link
Author

Following from #683, add an option to check for the bind-dev option and disable DCO. I'm not sure if this is the correct function to add it to.

Also, isn't bind-dev specific to Linux, so do I need to add it to an if block checking for Linux?

@cron2
Copy link
Contributor

cron2 commented Feb 16, 2025

@ordex I don't think we should disable DCO in this case. We should fix it inside DCO, not weasel out :-)

@ordex
Copy link
Member

ordex commented Feb 17, 2025

@ordex I don't think we should disable DCO in this case. We should fix it inside DCO, not weasel out :-)

@cron2 that's true, but for the time being it may be easier to let people know that this option is not supported.
Adding support to DCO (ovpn-dco or ovpn? ovpn-dco is in maintenance mode right now) may requires till some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants