Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GoodInstance to trading #308

Closed
wants to merge 1 commit into from
Closed

Conversation

wvpm
Copy link
Contributor

@wvpm wvpm commented Feb 13, 2025

GoodInstance should only be used in the context of trading and market price and therefor is moved to trading.

@wvpm wvpm enabled auto-merge February 13, 2025 09:31
@wvpm wvpm added the enhancement New feature or request label Feb 13, 2025
@wvpm
Copy link
Contributor Author

wvpm commented Feb 15, 2025

Rejected by Hop in order to keep GoodDefinition & GoodInstance together.
Instead I'll extract the trading code to a new type inside the trading folder and make it a member of GoodInstance.

@wvpm wvpm closed this Feb 15, 2025
auto-merge was automatically disabled February 15, 2025 00:33

Pull request was closed

@wvpm wvpm deleted the move_goodinstance_to_trading branch February 15, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant