[minor][doc] README corrections (ease of use) #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cters from copiable commands; Splitting commands from their responses; Indentations
MateuszGrabuszynski
requested review from
pwysock1-intel and
soopel
as code owners
skolelis
reviewed
Nov 12, 2024
skolelis
reviewed
Nov 12, 2024
skolelis
reviewed
Nov 12, 2024
|
lgtm |
Sakoram
reviewed
Nov 13, 2024
Sakoram
reviewed
Nov 13, 2024
…; removing manual libfabric installation requirement in OPTION B
skolelis
reviewed
Nov 13, 2024
|
Thank you for your reviews. It seems 2 approvals should mean it's ready to merge? |
Sakoram
previously approved these changes
Nov 14, 2024
|
New suggestions arose, please do not merge! |
Signed-off-by: Mateusz Grabuszyński <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @skolelis suggestions: