Fix atp updating #360
Merged
Fix atp updating #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huxuan0307
requested review from
cebarobot and
pxk27
and removed request for
cebarobot
* This commit correct the updating of hgatp CSR. * As descriped in spec, VMID and PPN fields in hgatp behavior as WARL in the normal way, regardless of new_val.mode. * Never set the remaining fields in hgatp to zeros when hgatp.MODE is bare, since this is set by software.
…ting * When hgatp.MODE=Bare, the width of vsatp.PPN should be the length of PADDR minus the length of in-page address. * When hgatp.MODE=Sv39x4, the width of vsatp.PPN should be 41 minus the length of in-page address.
pxk27
approved these changes
Jun 19, 2024
xinhecuican
pushed a commit
to xinhecuican/NEMU
that referenced
this pull request
Aug 31, 2024
* csr:update PPN and VMID field regardless of the new MODE * This commit correct the updating of hgatp CSR. * As descriped in spec, VMID and PPN fields in hgatp behavior as WARL in the normal way, regardless of new_val.mode. * Never set the remaining fields in hgatp to zeros when hgatp.MODE is bare, since this is set by software. * csr:make the effective bits of vsatp.PPN relies on the hgatp.MODE setting * When hgatp.MODE=Bare, the width of vsatp.PPN should be the length of PADDR minus the length of in-page address. * When hgatp.MODE=Sv39x4, the width of vsatp.PPN should be 41 minus the length of in-page address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.