area(ftq): use Vec(Reg) instead of template #3595
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[Generated by IPC robot]
master branch:
|
eastonman
force-pushed
the
area-remove-negedge-reg
branch
from
9ff8575 to
9088dcb
Compare
|
[Generated by IPC robot]
master branch:
|
eastonman
force-pushed
the
area-remove-negedge-reg
branch
from
9088dcb to
230cf4e
Compare
in previous code, SyncDataModuleTemplate is used, which uses negedge register (1.5 + 1.5 cycle write + read) with bypass to achieve the same behaviour as simple rdata := reg(RegNext(raddr)) this commits removes the template since we are not using negedge registers anymore. All the bypass logic used in 1.5 + 1.5 can be eliminated. Also, on some FTQ queue that does not require immediate read result, no bypass is need. The commit also removes there bypasses.
|
[Generated by IPC robot]
master branch:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in previous code, SyncDataModuleTemplate is used, which uses negedge register (1.5 + 1.5 cycle write + read) with bypass to achieve the same behaviour as simple rdata := reg(RegNext(raddr))
this commits removes the template since we are not using negedge registers anymore. All the bypass logic used in 1.5 + 1.5 can be eliminated. Also, on some FTQ queue that does not require immediate read result, no bypass is need. The commit also removes there bypasses.