feat(Svpbmt): support WMO memory access and outstanding of NC #3900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxpicca-Li
requested review from
weidingliu,
good-circle,
linjuanZ,
cz4e,
happy-lx,
cebarobot,
Lemover and
bosscharlie
as code owners
Maxpicca-Li
changed the title
Maxpicca-Li
changed the title
Maxpicca-Li
changed the title
|
[Generated by IPC robot]
master branch:
|
linjuanZ
requested changes
Nov 20, 2024
Comment on lines
+214
to
+215
| val ioBuffer = Module(new IOBuffer) // uncache io buffer | ||
| val ncBuffer = Module(new NCBuffer) // uncache nc buffer |
There was a problem hiding this comment.
Is it necessary to use two large buffers to save MMIO access and uncache access separately?
There was a problem hiding this comment.
It is not necessary. Merging them into a single buffer requires considering the characteristics that MMIO needs to be serialized while NC can be parallelized, which is one of the next optimization points.
|
[Generated by IPC robot]
master branch:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.