Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.0.8 #59

Merged
merged 1 commit into from
Feb 19, 2025
Merged

v1.0.8 #59

merged 1 commit into from
Feb 19, 2025

Conversation

Amxx
Copy link
Contributor

@Amxx Amxx commented Feb 18, 2025

Fixes #58

@Amxx Amxx requested review from frangio and ernestognw February 18, 2025 08:50
@Amxx
Copy link
Contributor Author

Amxx commented Feb 18, 2025 •
edited
Loading

Ideally, I would merge #57 first (into master, and then cherrypicked here)

@frangio
Copy link
Contributor

frangio commented Feb 18, 2025

#57 is merged now.

@Amxx
Copy link
Contributor Author

Amxx commented Feb 18, 2025

Actually, we don't need to cherrypick. We can just merge this, and tag/publish the resulting comming on master

@frangio
Copy link
Contributor

frangio commented Feb 18, 2025

That's a little confusing. I'd suggest rebasing this PR on master.

@Amxx Amxx merged commit 87caafd into master Feb 19, 2025
2 checks passed
@Amxx Amxx deleted the v1.0.8 branch February 19, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

@ernestognw ernestognw Awaiting requested review from ernestognw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider publishing a new version
2 participants
@Amxx @frangio