-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UnsafeUpgrades
library variations, add LegacyUpgrades.sol
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 239d32b.
ericglau
changed the title
Draft: Enable upgrading deployments using OpenZeppelin Contracts 4.x
Add library variations to support May 8, 2024
forge coverage
or upgrade deployments using OpenZeppelin Contracts 4.x
ericglau
changed the title
Add library variations to support
Add May 8, 2024
forge coverage
or upgrade deployments using OpenZeppelin Contracts 4.xUnsafeUpgrades
library variations, add LegacyUpgrades.sol
Amxx
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Fixes #44
Fixes #34
Overview of changes:
UPGRADE_INTERFACE_VERSION
in upgrade functions.UnsafeUpgrades
library variations in both Upgrades.sol and LegacyUpgrades.sol to work withforge coverage
.Note that
UnsafeUpgrades
does not perform any upgrade safety validations, so is not recommended for use with Forge scripts.Summary of how this was implemented:
Upgrades
andUnsafeUpgrades
libraries exist in both Upgrades.sol and LegacyUpgrades.sol.