feat: bitmap #119
feat: bitmap #119
Conversation
✅ Deploy Preview for contracts-stylus canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
I think yes. I can reuse this contract to build consecutive on top. We don't need to use stylus inheritance just aggregation |
| #[motsu::test] | ||
| fn set_value() { | ||
| proptest!(|(value: U256)| { | ||
| let mut bit_map = BitMap::default(); |
There was a problem hiding this comment.
This one seems a bit debatable decision, but now #[motsu::test] macro locks storage for a test execution even if there is no contract argument.
Assuming that rust contract struct can be created during test.
And the state of this contract will be single per test.
What do you think @alexfertel ? Or may be use with_context function?
There was a problem hiding this comment.
I think with_context is slightly cleaner because we are instantiating the contract twice this way (with default), right?
In any case, I'm fine either way, I'll leave it to your judgment!
| } | ||
|
|
||
| /// Get bucket index. | ||
| fn get_bucket(index: U256) -> U256 { |
There was a problem hiding this comment.
Should we #[inline] these? They are private & small.
There was a problem hiding this comment.
I used to think that those small and private functions should be unlined by default by rust compiler
| #[motsu::test] | ||
| fn set_value() { | ||
| proptest!(|(value: U256)| { | ||
| let mut bit_map = BitMap::default(); |
There was a problem hiding this comment.
I think with_context is slightly cleaner because we are instantiating the contract twice this way (with default), right?
In any case, I'm fine either way, I'll leave it to your judgment!
Co-authored-by: Alexander González <[email protected]>
Co-authored-by: Alexander González <[email protected]>
Co-authored-by: Alexander González <[email protected]>
Resolves #77