feat(erc721): add ERC721Enumerable extension (#67) #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
👷 Deploy request for contracts-stylus pending review.A Netlify team Owner will need to approve the deploy before you can run your build. Are you a team Owner? Visit the deploys page to approve it → Need more help? Learn more in the Netlify docs →
|
|
The author of this PR, bidzyyys, is not an activated member of this organization on Codecov. |
bidzyyys
force-pushed
the
feature/erc721-enumerable
branch
from
da4f10c to
3afa579
Compare
bidzyyys
requested review from
alexfertel and
qalisander
and removed request for
alexfertel
qalisander
reviewed
May 29, 2024
| &mut self, | ||
| from: Address, | ||
| token_id: U256, | ||
| erc721: &impl IERC721, |
There was a problem hiding this comment.
Pass it by interface seems as a good trade off. Cool!
alexfertel
previously approved these changes
May 31, 2024
| sol_storage! { | ||
| /// State of an Enumerable extension. | ||
| pub struct ERC721Enumerable { | ||
| /// TODO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #67
PR Checklist