Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage-related tests for Pull/41 #42

Open
wants to merge 3 commits into
base: fix-cached-storage-bug
Choose a base branch
from

Conversation

0xNeshi
Copy link
Collaborator

@0xNeshi 0xNeshi commented Feb 7, 2025

Add storage-related tests to verify expected behavior on storage cleanup

Related PR #41

@0xNeshi 0xNeshi self-assigned this Feb 7, 2025
@0xNeshi 0xNeshi changed the title Pull 41 new tests Add storage-related tests for Pull/41 Feb 7, 2025
@@ -254,26 +254,6 @@ mod ping_pong_tests {
assert_eq!(pong.sender(alice).contract_address.get(), pong.address());
}

#[motsu::test]
fn deref_invalidated_storage_cache(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of the contract_address test above it

@qalisander
Copy link
Member

qalisander commented Feb 7, 2025

Try to comment out both invocations of self.invalidate_storage_cache() functions and you will see that your test can still pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants