feat(shared-data): add 20ul tips #16885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthecoder
force-pushed
the
EXEC-836-add-20ul-tips
branch
from
90b31db to
28aacb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pulls in the previously orphaned branch that contained the cavity script and the work for the 20ul tips.
Since they were so coupled I'm just merging both in together after a rebase, and then adding some more that is required for the other pipettes we haven't tested yetDecided to do some git history re-writing for this instead to break it out into two clean PR's so this will just contain the 20ul tips part.
Currently the pipette functions are only valid for the P1000_96, P50_multi and P50_single, all the other pipettes are just placeholders
Additionally this PR uses the default tip overlap values for now and should be populated per-pipette once the hardware testing is complete
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment