-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(monorepo): Update Electron to v33.2.1 #17010
Draft
mjhuff
wants to merge
9
commits into
edge
Choose a base branch
from
update-electron-33.2.1
base: edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
force-pushed
the
update-electron-33.2.1
branch
8 times, most recently
from
December 3, 2024 01:39
eb01475
to
751ada5
Compare
mjhuff
force-pushed
the
update-electron-33.2.1
branch
from
December 3, 2024 02:02
751ada5
to
2c40681
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17010 +/- ##
==========================================
+ Coverage 79.20% 79.21% +0.01%
==========================================
Files 120 120
Lines 4516 4533 +17
==========================================
+ Hits 3577 3591 +14
- Misses 939 942 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
mjhuff
force-pushed
the
update-electron-33.2.1
branch
from
December 3, 2024 03:38
2c40681
to
13f8c0f
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EXEC-1032
Overview
Expect lots of rebases and tears.
This is based on #15894, thanks to @shlokamin and @koji!
Oe-core PR for updating node
NOTE: This should be merged alongside the oe-core PR.
Test Plan and Hands on Testing
Desktop Smoke Test
ODD Smoke Test
Changelog
Review requests
Risk assessment