Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(monorepo): Update Electron to v33.2.1 #17010

Draft
wants to merge 9 commits into
base: edge
Choose a base branch
from

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Dec 2, 2024

Closes EXEC-1032

Overview

Expect lots of rebases and tears.

This is based on #15894, thanks to @shlokamin and @koji!

Oe-core PR for updating node

NOTE: This should be merged alongside the oe-core PR.

Test Plan and Hands on Testing

Desktop Smoke Test

  • Protocol uploading (and DnD functionality) and custom labware uploading is fixed. See this issue for context.
  • Run a protocol.
  • Desktop electron-updater flow works.
  • Pushing an artifact to the ODD works.
  • USB detection and general app usage is fixed.
  • Run LPC.
  • Devtools work (at least as well as they have been working).

ODD Smoke Test

  • The uploaded artifact actually runs.
  • USB uploading an update artifact on the Flex works.
  • Devtools work (at least as well as they have been working).
  • Running an uploaded protocol works.

Changelog

Review requests

Risk assessment

@koji
Copy link
Contributor

koji commented Dec 2, 2024

@mjhuff
maybe utilize this? #15894

@mjhuff mjhuff force-pushed the update-electron-33.2.1 branch 8 times, most recently from eb01475 to 751ada5 Compare December 3, 2024 01:39
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.21%. Comparing base (1c0a01c) to head (2c40681).
Report is 14 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17010      +/-   ##
==========================================
+ Coverage   79.20%   79.21%   +0.01%     
==========================================
  Files         120      120              
  Lines        4516     4533      +17     
==========================================
+ Hits         3577     3591      +14     
- Misses        939      942       +3     
Flag Coverage Δ
shared-data 74.00% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants