Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix ODD map view nick name display issue #17019

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix(app): fix ODD map view nick name display issue #17019

merged 2 commits into from
Dec 4, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Dec 3, 2024

Overview

fix ODD map view nick name display issue

close RABR-679

Screenshot 2024-12-03 at 4 08 53 PM

Test Plan and Hands on Testing

  1. push abr-testing module to a Flex
    make -C abr-testing push-ot3 host={ip}

  2. send the attached protocol
    6_Omega_HDQ_DNA_Cells-Flex_96_channel.py.zip

  3. set up the protocol and go to labware

  4. display deck view and tap a labware to display labware details
    check a nick name is displayed

Changelog

Review requests

Risk assessment

low

fix ODD map view nick name display issue

close RABR-679
@koji koji requested review from mjhuff and ncdiehl11 December 3, 2024 21:15
@koji koji marked this pull request as ready for review December 3, 2024 21:15
@koji koji requested a review from a team as a code owner December 3, 2024 21:15
@koji koji marked this pull request as draft December 3, 2024 21:15
@koji koji changed the base branch from edge to chore_release-8.2.0 December 3, 2024 21:16
@koji koji marked this pull request as ready for review December 3, 2024 21:22
@koji koji changed the base branch from chore_release-8.2.0 to edge December 3, 2024 21:41
@koji koji requested a review from mjhuff December 4, 2024 00:07
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh yep, lgtm. Thank you!

@koji
Copy link
Contributor Author

koji commented Dec 4, 2024

@mjhuff
thank you for the quick review!

@koji koji merged commit d2d8d08 into edge Dec 4, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants