Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(protocol-designer): remove warning when run protocol-designer dev #17034

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from

Conversation

koji
Copy link
Contributor

@koji koji commented Dec 4, 2024

Overview

this should be for post-launch to avoid any unexpected issue.

  • make -C protocol-designer dev
  • make -C protocol-designer build
  • make check-js
  • make lint-js
  • make test-js

close RQA-3762

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

@koji koji marked this pull request as ready for review December 4, 2024 18:49
@koji koji requested a review from a team as a code owner December 4, 2024 18:49
@koji koji removed the request for review from a team December 4, 2024 18:50
@koji koji added the authorship label Dec 4, 2024
@koji koji changed the title fix(protocol-designer): remove warning when run protocol-designer dev chore(protocol-designer): remove warning when run protocol-designer dev Dec 4, 2024
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks Koji!

@koji koji added the DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authorship DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants