-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sensors): add a new can message to batch read sensor data #805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small readability and robustness changes and also definitely want some tests for the index math and logic
Marking as draft since Caila didn't get a chance to use this before her trip. I'll clean it up and make it better styled |
fe2b7aa
to
3cc1b99
Compare
3cc1b99
to
09557bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good to me!
In a first step to streamline tool_sensors.py we want to batch read sensor data, this will speed up the process and let us stream a lot better
This PR removes much of the complexity from tool sensors and puts creates a new log specifically for sensor data.