Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap svn for GitHub API calls #78

Merged
merged 12 commits into from
Feb 6, 2024
Merged

Swap svn for GitHub API calls #78

merged 12 commits into from
Feb 6, 2024

Conversation

harveysanders
Copy link
Contributor

@harveysanders harveysanders commented Feb 1, 2024 •
edited
Loading

  • WIP - Swap svn for GitHub API

TODO:

  • Ensure tests work with real creds
  • Mock GitHub API to fix tests

@harveysanders harveysanders changed the base branch from master to security/update-deps February 1, 2024 21:10
@harveysanders harveysanders marked this pull request as ready for review February 2, 2024 22:28
Base automatically changed from security/update-deps to master February 2, 2024 23:12
ptbarnum4
ptbarnum4 reviewed Feb 5, 2024
View reviewed changes
controller/github-api.js Outdated Show resolved Hide resolved
ptbarnum4
ptbarnum4 reviewed Feb 5, 2024
View reviewed changes
controller/github-api.js Outdated Show resolved Hide resolved
ptbarnum4
ptbarnum4 reviewed Feb 5, 2024
View reviewed changes
controller/github-api.js Outdated Show resolved Hide resolved
ptbarnum4
ptbarnum4 reviewed Feb 5, 2024
View reviewed changes
controller/test.js Outdated Show resolved Hide resolved
ptbarnum4
ptbarnum4 reviewed Feb 5, 2024
View reviewed changes
install.sh Outdated Show resolved Hide resolved
ptbarnum4
ptbarnum4 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@ptbarnum4 ptbarnum4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

alex-aaron
alex-aaron approved these changes Feb 5, 2024
View reviewed changes
Copy link

@alex-aaron alex-aaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all makes sense!

@ptbarnum4
Copy link
Contributor

@harveysanders is this the flaky test

@harveysanders
Copy link
Contributor Author

Yeah

@harveysanders
Copy link
Contributor Author

@harveysanders is this the flaky test

@ptbarnum4 yeah, they should be fixed on this commit now

@harveysanders harveysanders merged commit c7c2393 into master Feb 6, 2024
1 check passed
@harveysanders harveysanders deleted the chore/remove-svn branch February 6, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-aaron alex-aaron alex-aaron approved these changes

@ptbarnum4 ptbarnum4 ptbarnum4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harveysanders @ptbarnum4 @alex-aaron