CLI - allow unsetting optional references (IdentifierInput changes) (#…

…230)
OpsLevel · Dec 29, 2023 · a1adb29 · a1adb29
1 parent ff6c070
commit a1adb29
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 5 deletions.
diff --git a/.changes/unreleased/Bugfix-20231229-130258.yaml b/.changes/unreleased/Bugfix-20231229-130258.yaml
@@ -0,0 +1,3 @@
+kind: Bugfix
+body: Fix bugs where unset ID/IdentifierInput fields were not being omitted on update
+time: 2023-12-29T13:02:58.119377-05:00
diff --git a/.changes/unreleased/Bugfix-20231229-130331.yaml b/.changes/unreleased/Bugfix-20231229-130331.yaml
@@ -0,0 +1,3 @@
+kind: Bugfix
+body: Fix bugs where optional ID/IdentifierInput fields were not being unset on update
+time: 2023-12-29T13:03:31.586713-05:00
diff --git a/.gitignore b/.gitignore
@@ -4,3 +4,5 @@ src/dist
 .DS_Store
 go.work*
 **coverage.txt
+src/*.yaml
+
diff --git a/src/cmd/action.go b/src/cmd/action.go
@@ -75,7 +75,7 @@ var getActionCmd = &cobra.Command{
 	ArgAliases: []string{"ID", "ALIAS"},
 	Run: func(cmd *cobra.Command, args []string) {
 		key := args[0]
-		action, err := getClientGQL().GetCustomAction(*opslevel.NewIdentifier(key))
+		action, err := getClientGQL().GetCustomAction(key)
 		cobra.CheckErr(err)
 		common.PrettyPrint(action)
 	},
@@ -141,7 +141,7 @@ var deleteActionCmd = &cobra.Command{
 	ArgAliases: []string{"ID", "ALIAS"},
 	Run: func(cmd *cobra.Command, args []string) {
 		key := args[0]
-		err := getClientGQL().DeleteWebhookAction(*opslevel.NewIdentifier(key))
+		err := getClientGQL().DeleteWebhookAction(key)
 		cobra.CheckErr(err)
 		fmt.Printf("deleted webhook action: %s\n", key)
 	},

diff --git a/src/cmd/trigger_definition.go b/src/cmd/trigger_definition.go
@@ -69,7 +69,7 @@ var getTriggerDefinitionCmd = &cobra.Command{
 	ArgAliases: []string{"ID", "ALIAS"},
 	Run: func(cmd *cobra.Command, args []string) {
 		key := args[0]
-		triggerDefinition, err := getClientGQL().GetTriggerDefinition(*opslevel.NewIdentifier(key))
+		triggerDefinition, err := getClientGQL().GetTriggerDefinition(key)
 		cobra.CheckErr(err)
 		common.PrettyPrint(triggerDefinition)
 	},
@@ -129,7 +129,7 @@ var deleteTriggerDefinitionCmd = &cobra.Command{
 	ArgAliases: []string{"ID", "ALIAS"},
 	Run: func(cmd *cobra.Command, args []string) {
 		key := args[0]
-		err := getClientGQL().DeleteTriggerDefinition(*opslevel.NewIdentifier(key))
+		err := getClientGQL().DeleteTriggerDefinition(key)
 		cobra.CheckErr(err)
 		fmt.Printf("deleted trigger definition: %s\n", key)
 	},

diff --git a/src/submodules/opslevel-go b/src/submodules/opslevel-go
+3 −0		.changes/unreleased/Bugfix-20231228-152233.yaml
+4 −0		.changes/unreleased/Bugfix-20231229-114751.yaml
+3 −0		.changes/unreleased/Bugfix-20231229-125723.yaml
+3 −0		.changes/unreleased/Feature-20231228-102445.yaml
+4 −0		.changes/unreleased/Refactor-20231228-102145.yaml
+13 −13		actions.go
+9 −11		actions_test.go
+2 −2		check.go
+1 −1		check_custom_event.go
+1 −1		domain.go
+2 −2		infra.go
+3 −3		repository.go
+26 −8		scalar.go
+76 −43		scalar_test.go
+3 −4		scorecards.go
+2 −2		secrets_test.go
+2 −2		service.go
+2 −2		system.go
+2 −2		team.go
+2 −2		user.go