Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.UpdateService needed v2 of ServiceUpdateInput #321

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,8 @@ tasks:
cmds:
- task: install-gofumpt
- task: install-golangci-lint
- task: install-nilaway
- task: workspace
- task: lint
- task: has-latest-opslevel-dependencies
- task: test

debug:
Expand All @@ -49,7 +47,6 @@ tasks:
cmds:
- test -z "$(gofumpt -d -e . | tee /dev/stderr)"
- golangci-lint run --timeout 5m
#- nilaway -include-pkgs='github.com/opslevel/kubectl-opslevel' -test=false ./...

fix:
desc: Fix formatting and linting
Expand All @@ -69,7 +66,6 @@ tasks:
- task: install-changie
- task: install-gofumpt
- task: install-golangci-lint
- task: install-nilaway
- cmd: echo "Development tools installed!"
silent: true
- task: workspace
Expand Down Expand Up @@ -99,18 +95,6 @@ tasks:
- cmd: echo "submodules ready!"
silent: true

has-latest-opslevel-dependencies:
desc: Check if opslevel dependencies are up to date in go.mod
dir: "{{.SRC_DIR}}"
silent: true
cmds:
- defer: { task: undo-ignore-go-work-files }
- task: tmp-ignore-go-work-file
- for: [ "{{.OPSLEVEL_GO_PKG}}", "{{.OPSLEVEL_JQ_PARSER_PKG}}", "{{.OPSLEVEL_K8S_CONTROLLER_PKG}}" ]
task: has-latest-opslevel-dep
vars:
OPSLEVEL_PKG: "{{.ITEM}}"

# internal (not directly called) tasks

tmp-ignore-go-work-file:
Expand Down Expand Up @@ -183,13 +167,6 @@ tasks:
- task: go-install-tool
vars: { GO_TOOL: "dlv", GO_TOOL_PATH: "github.com/go-delve/delve/cmd/dlv@latest" }

install-nilaway:
desc: go install "nilaway"
internal: true
cmds:
- task: go-install-tool
vars: { GO_TOOL: "nilaway", GO_TOOL_PATH: "go.uber.org/nilaway/cmd/nilaway@latest" }

install-gofumpt:
desc: go install "gofumpt"
internal: true
Expand Down
2 changes: 1 addition & 1 deletion src/common/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func NewOpslevelClient(client *opslevel.Client) *OpslevelClient {
return client.CreateService(input)
},
UpdateServiceHandler: func(input opslevel.ServiceUpdateInput) (*opslevel.Service, error) {
return client.UpdateService(input)
return client.UpdateService(opslevel.ConvertServiceUpdateInput(input))
},
CreateAliasHandler: func(input opslevel.AliasCreateInput) error {
_, err := client.CreateAlias(input)
Expand Down
2 changes: 1 addition & 1 deletion src/submodules/opslevel-jq-parser
2 changes: 1 addition & 1 deletion src/submodules/opslevel-k8s-controller
Loading