Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ eliminate checks on user approval #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

naiba
Copy link

@naiba naiba commented Feb 9, 2023

Hi there, I think the check for the "approve" data is not necessary, it is the user's freedom to decide which accounts of which chains they want to connect or approve which methods to provide which events.

Instead, if the Dapp confirms that "approve" is needed under certain chains, the Dapp side needs to go detect and alert the user, not force the user to "approve" the chains.

@Abhimanyu121
Copy link
Contributor

@thelazyindian can you check this one as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants