This repository has been archived by the owner on Oct 14, 2024. It is now read-only.
forked from mattdesl/three-orbit-controls
-
Notifications
You must be signed in to change notification settings - Fork 0
Double-click/tap zoom #1
Open
ghost
wants to merge
16
commits into
peek
Choose a base branch
from
zoom
base: peek
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
09d75f0
double-click zoom
4a39f94
double-click/tap zoom support for touch/hybrid devices
8b63cf2
reformat code according to Mr.doob's Code Style
a835fba
limit double-tap detection area
0007476
Fix double-tap detection
3d2f786
Refactor double-tap detection
2db544d
Simplify 'toggleZoom' and rename it to 'setZoom'
dc11e02
Expose zoomScaleStream
dde2e4d
Add 'kefir' to devDependencies
864a164
Fix double-tap detection
f654582
Add a setter to zoomScale property
08ac804
Remove 'zoomScaleStream' property
68257cd
Refactor 'setZoomScale'
5edf1f7
Refactor zoom
d3b0d4d
Cleanup
8555a79
Remove useless code
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
var clicks = 0 | ||
var wait = 300 | ||
var doubleTapRadius = 24 | ||
var lastClick = null | ||
var distFromLastClick = 0 | ||
|
||
function isDoubleClick( event ) { | ||
|
||
var click = event.changedTouches && event.changedTouches[0] || event | ||
click.type = event.type | ||
|
||
if ( lastClick !== null ) { | ||
|
||
if ( lastClick.type !== click.type ) return false | ||
|
||
var horizontalDist = click.pageX - lastClick.pageX | ||
var verticalDist = click.pageY - lastClick.pageY | ||
distFromLastClick = Math.sqrt( Math.pow( horizontalDist, 2 ) + Math.pow( verticalDist, 2 ) ) | ||
|
||
} else { | ||
|
||
lastClick = click | ||
distFromLastClick = 0 | ||
|
||
} | ||
|
||
if ( distFromLastClick <= doubleTapRadius ) clicks++ | ||
|
||
if ( clicks !== 2 ) { | ||
|
||
setTimeout(function () { | ||
|
||
clicks = 0 | ||
lastClick = null | ||
|
||
}, wait) | ||
|
||
return false | ||
|
||
} else { | ||
|
||
return true | ||
|
||
} | ||
} | ||
|
||
module.exports = isDoubleClick |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the doubletap can be initiated only after the touch state has been completed - after state = STATE.NONE;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean this code block should be placed after state = STATE.NONE; ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes