This repository has been archived by the owner on Dec 21, 2017. It is now read-only.
v0.3.0 #6
Open
v0.3.0 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has been updated.
IndexAnalyzer and the DecimalAnalyzer. Filtering (with, without) and sorting (order_by) use now the right field name.
documents were extracted from the ActiveRecord instance. Two related test cases have been added.
tests was correct when each model item was checked separately. Now the test checks the full model.
- Loading all records from the database at once + manual reordering to match OSS result. - Added :include option to #oss_search & #find_results to eager load associations. - Using after_commit instead of after_save for indexing documents. Other minor things: - Renamed #search to #oss_search (with alias) for simpler custom searches in models. - Overall ruby syntax & functional code refactoring.
Fixes & optimizations to Searchable
dependecy (oss_rb)
Conflicts: lib/oss_active_record/searchable.rb
FIXME: refactor IndexInstance to either receive index as dependency or lazy build it on each public method.
…ts_for_nil_class Create index object when needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.