Add top(header) menu #641
Add top(header) menu #641
Conversation
| @@ -38,13 +38,15 @@ | |||
| public static final String NAME = "perspectives"; | |||
| public static final String OCLASS_PERSPECTIVE="OPerspective"; | |||
| public static final String OCLASS_ITEM = "OPerspectiveItem"; | |||
| public static final String OCLASS_TOP_ITEM = "OPerspectiveTopItem"; | |||
There was a problem hiding this comment.
Why these 2 classes additionally needed? There is already class for menu items for left menu - lets just use that.
There was a problem hiding this comment.
Top menu not support recursive trees display. Only top level and dropdowns.All - without icons.
| link.add(new AttributeAppender("class", " active")); | ||
| } | ||
| if (hasSubItems){ | ||
| link.add(new AttributeModifier("aria-expanded", "false")); |
There was a problem hiding this comment.
Why these lines needed? It can be coded right in HTML.
There was a problem hiding this comment.
If i do - all links show as dropdowns
| @@ -12,6 +12,9 @@ | |||
| <span class="navbar-toggler-icon"></span> | |||
| </button> | |||
|
|
|||
| <nav class="navbar navbar-expand-lg" wicket:id="topMenu"> | |||
There was a problem hiding this comment.
Is menu looks good from mobile? Menu should be just collapsed.
There was a problem hiding this comment.
It is bootstrap menu. I think mobile devices supported.
| @@ -79,6 +79,7 @@ public boolean isEnabled(Component component) { | |||
|
|
|||
| @Override | |||
| protected void populateItem(final ListItem<ODocument> item) { | |||
| item.setRenderBodyOnly(true); | |||
There was a problem hiding this comment.
Commonly it's not recommended because of AJAX. Why it's needed?
There was a problem hiding this comment.
In bootstrap4 dropdowns use links directly, without external tags.
No description provided.