Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

fix a problem with metamask 4.12.0 #101

Closed
wants to merge 1 commit into from

Conversation

sparrowDom
Copy link
Member

origin-js crashes when creating a listing with Metamask 4.12.0. More details about the problem in this issue: OriginProtocol/origin-js#587

@micahalcorn
Copy link
Member

@sparrowDom I don't quite understand what's happening here. The PROVIDER_URL env var is only supposed to be used if there is no Web3 support in the browser. So if you have MetaMask, you shouldn't ever get to this. 🤔

@sparrowDom
Copy link
Member Author

@micahalcorn yeah that makes no sense... let me investigate more

@sparrowDom
Copy link
Member Author

hmm lets close this for now, since I can't consistently reproduce the problem/solution

@sparrowDom sparrowDom closed this Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants