Hardhat tasks #2234

naddison36 · 2024-09-15T03:00:54Z

New Hardhat tasks exitValidators and removeValidators make it easier to bulk exit and remove validators.
Added Base support for vault hardhat tasks. eg npx hardhat snapVault --network base
Added Hardhat task manuallyFixAccounting
Created ForceEtherSender contract to transfer ETH to contracts on self destruct
Added mine Hardhat task that mines a number of blocks
Added snapAero Hardhat task

The bulk Hardhat tasks are an alternative off-chain solution to PR #2185

Example snapAero task

npx hardhat snapAero --network base

Pool price       : 0.9999818609 OETHb/WETH, -1 tick
Pool WETH        : 6642.222726861587167611 (19.89%), 6642222726861587167611 wei
Pool OETH        : 26737.010414482733100435 (80.1%), 26737010414482733100435 wei
Pool total       : 33379.233141344320268046

Tick WETH        : 5921.046466451057867835 (18.14%), 5921046466451057867835 wei
Tick OETH        : 26718.611544742131398853 (81.85%), 26718611544742131398853 wei
Tick total       : 30088.173428977392745968 97.78% of pool

Tick strat WETH  : 5458.190551583556444397 (18.14%), 6642222726861587167611 wei
Tick strat OETH  : 24629.982877393836301571 (81.85%), 26737010414482733100435 wei
Tick strat total : 30088.173428977392745968 92.18% of tick, 90.14% of pool

Strategy balance : 30088.123925492579520043 ether, 30088123925492579520043 wei
Vault WETH       : 74.209998063405065213, 74209998063405065213 wei

codecov · 2024-09-15T03:06:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.57%. Comparing base (d5c237c) to head (09967c6).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2234   +/-   ##
=======================================
  Coverage   56.57%   56.57%           
=======================================
  Files          75       75           
  Lines        3848     3848           
  Branches     1014     1014           
=======================================
  Hits         2177     2177           
  Misses       1668     1668           
  Partials        3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Added simulation Hardhat tasks deployForceEtherSender and forceSend

github-actions · 2024-09-16T01:37:03Z

	Warnings
⚠️	👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 09967c6

openzeppelin-code · 2024-09-16T01:54:35Z

Hardhat tasks

Generated at commit: 09967c614f2d21cf6b259bf748ef2792b484f147

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	3 3 0 18 42 66
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

For more details view the full report in OpenZeppelin Code Inspector

Added mine Hardhat task

sparrowDom

LGTM left a couple of comments

sparrowDom · 2024-09-16T08:00:23Z

contracts/tasks/aero.js

+  const sugarHelper = await resolveContract(base.sugarHelper, "ISugarHelper");
+
+  const Q96 = BigNumber.from(2).pow(96);
+  const sqrtRatioX96TickLower = BigNumber.from("79224201403219477170569942574"); // -1 tick


These could be read from the strategy contract. Would make it easier to use the same script for different strategies:
https://github.com/OriginProtocol/origin-dollar/blob/master/contracts/contracts/strategies/aerodrome/AerodromeAMOStrategy.sol#L87

Good idea. I'll add

sparrowDom · 2024-09-16T08:01:18Z

contracts/tasks/aero.js

+  const weth = await resolveAsset("WETH");
+  const vault = await resolveContract("OETHBaseVaultProxy", "IVault");
+  const oeth = await resolveContract("OETHBaseProxy", "OETHBase");
+  const pool = await resolveContract(base.aerodromeOETHbWETHClPool, "ICLPool");


nit: could be read from the strategy contract:
https://github.com/OriginProtocol/origin-dollar/blob/master/contracts/contracts/strategies/aerodrome/AerodromeAMOStrategy.sol#L75

could, but I'll leave it from addresses.js

sparrowDom · 2024-09-16T08:02:17Z

contracts/tasks/aero.js

+  ); // 0 tick
+
+  const { tick, sqrtPriceX96 } = await pool.connect(signer).slot0({ blockTag });
+  const { liquidityGross } = await pool.connect(signer).ticks(-1, { blockTag });


the -1 tick is true for this strategy, might be a different thing for other chain strategies. Available as a constant here: https://github.com/OriginProtocol/origin-dollar/blob/master/contracts/contracts/strategies/aerodrome/AerodromeAMOStrategy.sol#L67

good idea. I'll change

sparrowDom · 2024-09-16T08:06:19Z

contracts/tasks/aero.js

+    .mul(10000000000)
+    .div(Q96)
+    .div(Q96);
+  const poolWethBalance = await weth


good to know this isn't WETH liquidity in the pool, rather WETH balance/tokens of the pool.
WETH balance = WETH liquidity + unclaimed WETH
Unclaimed WETH can originate from decreasing liquidity in the pool and not yet collecting it. (the decrease + collect are separate calls).
In most cases though the WETH on the pool will probably be the pool's liquidity.
Also I think the WETH swap fees remain on the pool (since those are claimed by the veAreo voters)

I'll add the pool balances so we can see when its different to the actual WETH balance

I thought there was a getBalances function but there isn't. It needs to be calculated from the sqrtPriceX96 and liquidity. I'll leave for now but can add if you thinks its useful information

Yeah it is pretty annoying that there isn't a simple way to get that data off of the contract

sparrowDom · 2024-09-16T08:09:11Z

contracts/tasks/aero.js

+  console.log(
+    `Pool price       : ${formatUnits(poolPrice, 10)} OETHb/WETH, ${tick} tick`
+  );
+  console.log(


I think these are fine, maybe there should be just additional notice, that these balances include unclaimed WETH/OETH from swap fees and liquidity decreases.

I've added a comment

Added bulk Hardhat tasks exitValidators and removeValidators

1905e81

naddison36 requested review from sparrowDom, DanielVF, shahthepro and clement-ux as code owners September 15, 2024 03:00

Added base support for vault hardhat tasks

4f68266

naddison36 changed the title ~~Added bulk Hardhat tasks exitValidators and removeValidators~~ Hardhat tasks Sep 16, 2024

Added manuallyFixAccounting hardhat task (#2229)

b380bcf

Added simulation Hardhat tasks deployForceEtherSender and forceSend

naddison36 added 6 commits September 16, 2024 13:25

manuallyFixAccounting now supports using scaled up amounts

7b887b1

Added mine Hardhat task

Added snapAero Hardhat task

e4f879f

Added strategy's tick positions

91cd715

More data to snapAero HH task

63cc9e2

Prettier

b9cf497

Added missing blockTag params

57ad699

sparrowDom previously approved these changes Sep 16, 2024

View reviewed changes

review comments

6c01fbe

naddison36 dismissed sparrowDom’s stale review via 6c01fbe September 16, 2024 09:44

prettier

09967c6

naddison36 merged commit a9676f4 into master Sep 16, 2024
15 of 18 checks passed

naddison36 deleted the nicka/hh-bulk-exit branch September 16, 2024 10:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hardhat tasks #2234

Hardhat tasks #2234

naddison36 commented Sep 15, 2024 •

edited

Loading

codecov bot commented Sep 15, 2024 •

edited

Loading

github-actions bot commented Sep 16, 2024 •

edited

Loading

openzeppelin-code bot commented Sep 16, 2024 •

edited

Loading

sparrowDom left a comment

sparrowDom Sep 16, 2024

naddison36 Sep 16, 2024

sparrowDom Sep 16, 2024

naddison36 Sep 16, 2024

sparrowDom Sep 16, 2024

naddison36 Sep 16, 2024

sparrowDom Sep 16, 2024

naddison36 Sep 16, 2024

naddison36 Sep 16, 2024

sparrowDom Sep 16, 2024

sparrowDom Sep 16, 2024

naddison36 Sep 16, 2024

Hardhat tasks #2234

Hardhat tasks #2234

Conversation

naddison36 commented Sep 15, 2024 • edited Loading

Example snapAero task

codecov bot commented Sep 15, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 16, 2024 • edited Loading

openzeppelin-code bot commented Sep 16, 2024 • edited Loading

Hardhat tasks

🚨 Report Summary

sparrowDom left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naddison36 commented Sep 15, 2024 •

edited

Loading

codecov bot commented Sep 15, 2024 •

edited

Loading

github-actions bot commented Sep 16, 2024 •

edited

Loading

openzeppelin-code bot commented Sep 16, 2024 •

edited

Loading