WIP Sonic Staking #2335
Draft
WIP Sonic Staking #2335
+6,071
−1,555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…root with an invalid signature
Added Natspec
* add withdrawal events to the tests * add WETH accounting * add better documentation * add sending WETH to the Vault back to fix manual accounting function * actually wrap the ETH to WETH before sending it to the Vault when manually fixing accounting * add withdrawal event to manually fix accounting * fix bugs and add tests with WETH accounting * add test to verify correct deposits * Gas changes to Native Staking's depositAll --------- Co-authored-by: Nicholas Addison <[email protected]>
* Deployed new NativeStakingSSVStrategy * Generated latest Native Staking Strategy diagrams
* deploy native staking proxy and add auxiliary functions to transfer its governance * Shortened error message in InitializeGovernedUpgradeabilityProxy.initialize --------- Co-authored-by: Nicholas Addison <[email protected]>
* deploy native staking proxy and add auxiliary functions to transfer its governance * Setup basic defender action * update defender-sdk version * add defender client as an external export * configuration update --------- Co-authored-by: Nicholas Addison <[email protected]>
claimWithdrawal collects from Dripper and adds any unallocated WETH to the withdrawal queue if not enough liquidity available
depositToStrategy only deposits WETH not allocated to the withdrawal queue swapCollateral restricted to only swap to WETH swapCollateral adds to withdrawal queue after swap
Fix upgrade script of OETHBase
sparrowDom
reviewed
Jan 9, 2025
| } | ||
| } | ||
|
|
||
| // TODO use Deposit event or something else? |
There was a problem hiding this comment.
Maybe we can add a bool flag isRestake to Deposit event indicating whether it is a normal deposit or restaking of the rewards
sparrowDom
reviewed
Jan 9, 2025
| */ | ||
| receive() external payable { | ||
| require( | ||
| msg.sender == sfc || msg.sender == wrappedSonic, |
There was a problem hiding this comment.
This is a nice check, but there is this little devil lurking around :)
There was a problem hiding this comment.
I don't think that donating S to the contract would throw off the math:
- We do the
address(this).balanceonly in thewithdrawFromTheSFCand we are looking at the increment that the withdrawal has caused... ignoring previous amount - Also the checkBalance does ignore the
Sbalance on the contract.
The only complaint I have that the check might give a false sense of security, since anyone can call withdrawTo and send S to the contract
Added governor transfer unit tests
Updated existing OToken diagrams after Yield Delegation
…he Sonic Staking Strategy
Added missing Vault config to Sonic deploy script Sonic Staking Strategy governor fixed in deploy script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
Contracts
Tests
Sonic Unit Tests
The Sonic unit tests are in
contracts/test/vault/os-vault.sonic.js.Sonic Fork Tests
The Sonic fork tests are in:
contracts/test/strategies/sonicStaking.sonic.fork-test.jscontracts/test/zapper/osonic-zapper.sonic.fork-test.jsDeployment
The first Sonic mainnet deployment file is
contracts/deploy/sonic/001_origin_sonic.jsCode Change Checklist
To be completed before internal review begins:
Internal review: