Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setRewardProceedsAddress on OETHHarvester to point to FixedRateDripper. #2361

Closed

Conversation

clement-ux
Copy link
Contributor

Code Change Checklist

  • No code change.

Deployment

  • 119_set_reward_proceeds_to_fixed_rate_dripper.js

Governance

  • Proposal id:
  • Proposal tx:
  • Proposal payload:
[
  [
    "0x0D017aFA83EAce9F10A8EC5B6E13941664A6785C"
  ],
  [
    {
      "type": "BigNumber",
      "hex": "0x00"
    }
  ],
  [
    "setRewardProceedsAddress(address)"
  ],
  [
    "0x000000000000000000000000e3b3b4fc77505ecfaacf6dd21619a8cc12fcc501"
  ]
]

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 51.41%. Comparing base (097f3f3) to head (27bbf89).

Files with missing lines Patch % Lines
...ontracts/contracts/harvest/OETHHarvesterSimple.sol 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2361      +/-   ##
==========================================
- Coverage   51.94%   51.41%   -0.54%     
==========================================
  Files          91       91              
  Lines        4414     4425      +11     
  Branches     1162     1166       +4     
==========================================
- Hits         2293     2275      -18     
- Misses       2118     2147      +29     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

// Governance Actions
// ----------------
return {
name: "Switch to multichain guardian",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Proposal name will need updating

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, my bad.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in this commit: a31cf64

Copy link
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add transferring any remaining WETH in the old Dripper to the new fixed rate dripper using transferAllToken

Copy link

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 27bbf89

@clement-ux
Copy link
Contributor Author

Closing this PR to change branch name.

@clement-ux clement-ux closed this Jan 23, 2025
@clement-ux clement-ux deleted the clement/setRewardProceeds-to-FixedRateDripper branch January 23, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants