-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setRewardProceedsAddress
on OETHHarvester to point to FixedRateDripper.
#2361
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2361 +/- ##
==========================================
- Coverage 51.94% 51.41% -0.54%
==========================================
Files 91 91
Lines 4414 4425 +11
Branches 1162 1166 +4
==========================================
- Hits 2293 2275 -18
- Misses 2118 2147 +29
Partials 3 3 ☔ View full report in Codecov by Sentry. |
// Governance Actions | ||
// ---------------- | ||
return { | ||
name: "Switch to multichain guardian", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Proposal name will need updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, my bad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in this commit: a31cf64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add transferring any remaining WETH in the old Dripper to the new fixed rate dripper using transferAllToken
Closing this PR to change branch name. |
Code Change Checklist
Deployment
119_set_reward_proceeds_to_fixed_rate_dripper.js
Governance
Deploy checklist
Two reviewers complete the following checklist: