Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of a Windows dev environment setup doc #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Aescwine
Copy link

Documentation for Windows development environment setup using WSL.

Copy link
Contributor

@Valcyclovir Valcyclovir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great way to run the node on Windows using WSL 2.

There are a few things that seem to be outdated:

  1. You should use on line 92
    git checkout v6/release/testnet

  2. The .env file doesn't require PUBLIC and PRIVATE keys anymore

  3. Missing creation of .origintrail_noderc in the instructions, but they are similar to the ones provided on the dockerless guide

  4. I see you are not using forever to keep the node running, which I personally do not like either. I suggest creating services for graphdb, mysql and the node to have them all running in the background. Refer to my commit for the exact service to add, if you wish.

@NZT48
Copy link
Collaborator

NZT48 commented Feb 11, 2022

Thanks @Aescwine, will try to forward to some team mate next week to test it out. It would be awesome if you could take a look at try to adapt local network setup tool to start a network of nodes on windows, it is useful for development.

@Valcyclovir thanks for review, just to add some additional info, this should be instructions for running ot-node in local environment for development. So instructions should have git checkout v6/develop. Public and private keys in env are used for running network using local network tool, so depends if this instructions are expanded to that script. No need for using forever for development, it is enough to start the node to see if it works.

@Aescwine
Copy link
Author

@NZT48 thanks. I've taken a look at adapting the local network setup tool for windows WSL, but to no avail yet. I've got so far as opening new terminals for the nodes, but haven't been successful getting the node start command to execute using the script. I'll take another look later in the week if I get some time.

@Aescwine
Copy link
Author

@NZT48 I've open a PR for a script to create multiple node configs for running a multi node network on Windows WSL: https://github.com/OriginTrail/ot-node/pull/1763/files

It differs from the MacOS version in that the nodes need to be started manually, but all the config generation is automated, so I still think it is beneficial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants