-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public/private rework #195
Merged
Mihajlo-Pavlovic
merged 11 commits into
v8/kcs-integration
from
v8/public-private-pairing-rework
Dec 16, 2024
Merged
Public/private rework #195
Mihajlo-Pavlovic
merged 11 commits into
v8/kcs-integration
from
v8/public-private-pairing-rework
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brkagithub
reviewed
Dec 14, 2024
tokensCount += publicTriplesGrouped.length; | ||
|
||
// Create a map of public subject -> index for quick lookup | ||
const publicSubjectMap = new Map(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const publicSubjectMap = new Map(); | |
const publicSubjectMap = new Map( | |
publicTriplesGrouped.map(([triple], index) => [triple.split(' ')[0], index]) | |
); | |
you can do tihs in one liner very cleanly imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and remove stuff below
brkagithub
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.