Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public/private rework #195

Merged
merged 11 commits into from
Dec 16, 2024

Conversation

Mihajlo-Pavlovic
Copy link
Collaborator

No description provided.

tokensCount += publicTriplesGrouped.length;

// Create a map of public subject -> index for quick lookup
const publicSubjectMap = new Map();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const publicSubjectMap = new Map();
const publicSubjectMap = new Map(
publicTriplesGrouped.map(([triple], index) => [triple.split(' ')[0], index])
);

you can do tihs in one liner very cleanly imo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and remove stuff below

@Mihajlo-Pavlovic Mihajlo-Pavlovic merged commit 8a1fc08 into v8/kcs-integration Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants