Improved IPv6 Handling for Nmap Agent

[nmasdoufi-ol]

Enhancements to IPv6 Handling in NmapAgent

This PR introduces several improvements and enhancements to the IPv6 handling logic in the NmapAgent class. The changes include validation of IPv6 settings, normalization of IPv6 addresses, and updates to subnet handling during the scanning process. Additionally, the PR modifies the process method to ensure that invalid or misconfigured IPv6 addresses and subnets are properly handled.

Key Changes:

1. IPv6 Validation Enhancements:

   • Introduced a _validate_ipv6_settings method to validate IPv6-specific settings.
   • This method ensures that the configured max_network_mask_ipv6 is within the allowed range (IPV6_MIN_PREFIX to 128).
   • If the validation fails, a ValueError is raised with an appropriate error message.

2. IPv6 Address Normalization:

   • Implemented the _normalize_ipv6_address method to normalize IPv6 addresses into their compressed format.
   • The method uses the ipaddress.IPv6Address class to validate and compress IPv6 addresses. If an invalid address is provided, it raises an AddressValueError, which is logged with an error message.

3. IPv6 Subnet Handling:

   • In the process method, added logic to handle IPv6 subnets:
     • If the subnet mask is below IPV6_CIDR_LIMIT, a ValueError is raised to prevent further processing.
     • If the subnet mask is valid, the address is normalized and scanned.
   • Added checks to ensure that subnet masks below the allowed limits for IPv6 (IPV6_CIDR_LIMIT) are properly handled with an error message.

4. IPv6 Scan Options:

   • Introduced a _get_ipv6_scan_options method to retrieve IPv6-specific scan options, including parameters like ping_timeout, min_rate, max_rate, max_retries, and fragment_mtu.
   • These options are now configurable via the agent’s arguments and are used during IPv6 scanning.

5. Logging and Error Reporting:

   • Added detailed logging to capture invalid IPv6 address errors and subnet mask issues.
   • When invalid subnets are encountered, the error message is logged, and further processing is halted.
   • For valid addresses, the processing continues as usual, with network scanning and vulnerability reporting.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.94%. Comparing base (fd705b7) to head (a7eaf3c).
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   94.74%   94.94%   +0.20%     
==========================================
  Files           9        9              
  Lines         932      970      +38     
==========================================
+ Hits          883      921      +38     
  Misses         49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ErebusZ]

This is not used anywhere